feat: add a confirmation modal on delete a bounty #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevkevinpal
reviewed
Sep 22, 2023
kevkevinpal
reviewed
Sep 22, 2023
kevkevinpal
reviewed
Sep 25, 2023
Comment on lines
+41
to
+43
| hovercolor={'#E96464'} | ||
| activecolor={'#E15A5A'} | ||
| shadowcolor={'#ED747480'} |
There was a problem hiding this comment.
we can be using a const color for these
kevkevinpal
reviewed
Sep 25, 2023
|
|
||
| {children} | ||
| <Stack width="100%" direction="row" justifyContent="space-between"> | ||
| <IconButton width={120} height={44} color="white" text="Cancel" onClick={closeHandler} /> |
There was a problem hiding this comment.
we can be using a const color here
kevkevinpal
reviewed
Sep 25, 2023
| @@ -456,7 +492,7 @@ function FocusedView(props: FocusViewProps) { | |||
| config={config} | |||
| fromBountyPage={fromBountyPage} | |||
| extraModalFunction={props?.extraModalFunction} | |||
| deleteAction={deleteIt} | |||
| deleteAction={canDeleteBounty ? deleteHandler : undefined} | |||
There was a problem hiding this comment.
can we use && instead of ? here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
closes #636
Type of change
Please delete options that are not relevant.
Checklist before requesting a review