Fix/proxy payment #745
Merged
Fix/proxy payment #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevkevinpal
reviewed
Sep 26, 2023
handlers/bounty.go
Outdated
Comment on lines
316
to
320
| if request.RouteHint != "" { | ||
| bodyData = fmt.Sprintf(`{"amount": %d, "destination_key": "%s", "route_hint": "%s"}`, amount, request.ReceiverPubKey, request.RouteHint) | ||
| } else { | ||
| bodyData = fmt.Sprintf(`{"amount": %d, "destination_key": "%s"}`, amount, request.ReceiverPubKey) | ||
| } |
There was a problem hiding this comment.
Looks like were doing this in two locations it might make more sense to make this a util than repeating code
handlers/invoiceCron.go
Outdated
Comment on lines
74
to
79
| var bodyData string | ||
| if inv.Route_hint != "" { | ||
| bodyData = fmt.Sprintf(`{"amount": %s, "destination_key": "%s", "route_hint": "%s"}`, inv.Amount, inv.User_pubkey, inv.Route_hint) | ||
| } else { | ||
| bodyData = fmt.Sprintf(`{"amount": %s, "destination_key": "%s"}`, inv.Amount, inv.User_pubkey) | ||
| } |
There was a problem hiding this comment.
Looks like were doing this in two locations it might make more sense to make this a util than repeating code
There was a problem hiding this comment.
I have created a util function for it.
|
looks good to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR removes the capitalization of organization names and adds a route hint for proxy users' keysend payments.
Issue ticket number and link
Closes #739
Closes #738
Type of change
Checklist before requesting a review