Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/people tab #807

Merged
merged 12 commits into from
Oct 12, 2023
Merged

Fix/people tab #807

merged 12 commits into from
Oct 12, 2023

Conversation

tobi-bams
Copy link
Contributor

Describe your changes

Issue ticket number and link

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • It has been deployed to people-test.sphinx.chat and tested by others

@tobi-bams tobi-bams linked an issue Oct 10, 2023 that may be closed by this pull request
@ecurrencyhodler
Copy link
Contributor

ecurrencyhodler commented Oct 10, 2023

Thanks Tobi! In the future, if we can include the language "Closes #791" in the PR description then github will auto close the issue once this gets merged.

@tobi-bams
Copy link
Contributor Author

Thanks Tobi! In the future, if we can include the language "Closes #791" in the PR description then github will auto close the issue once this gets merged.

Ops, when you link an issue to a PR, once the PR is merged it automatically closes the Issue.
That was why I linked the issue to this PR @ecurrencyhodler

@ecurrencyhodler
Copy link
Contributor

Ah okay that makes sense. Thanks for explaining that!

@kevkevinpal kevkevinpal merged commit e373df4 into master Oct 12, 2023
2 of 3 checks passed
@Evanfeenstra Evanfeenstra deleted the fix/people-tab branch January 26, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable viewing people page after seeing a profile.
3 participants