Fix/bounty paid state #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 12, 2023
Closed
|
@tobi-bams Please can you fix the merge conflicts, thanks. |
elraphty
requested changes
Oct 19, 2023
frontend/app/src/people/widgetViews/summaries/wantedSummaries/CodingBounty.tsx
Outdated
Show resolved
Hide resolved
elraphty
approved these changes
Oct 19, 2023
kevkevinpal
approved these changes
Oct 19, 2023
| @@ -247,7 +247,7 @@ function FocusedView(props: FocusViewProps) { | |||
| let newBody = cloneDeep(body); | |||
|
|
|||
| if (config && config.name === 'about') { | |||
| await main.saveProfile(newBody); | |||
| const res = await main.saveProfile(newBody); | |||
There was a problem hiding this comment.
not sure why we have this new res var if its not being used
Comment on lines
+111
to
+113
| } | ||
|
|
||
| if (localPaid === 'UNPAID') { |
There was a problem hiding this comment.
why not do else if here?
There was a problem hiding this comment.
Hmmmm, that's true. I can't remember why I did it that way.
But will push an update with my next PR. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Type of change
Please delete options that are not relevant.
Checklist before requesting a review