Startup modal polish #821
Merged
Startup modal polish #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicpotato137
commented
Oct 13, 2023
| height={48} | ||
| buttonType={'text'} | ||
| style={{ color: '#83878b', marginTop: '0px', textDecoration: 'none' }} | ||
| {!connection_string ? ( |
There was a problem hiding this comment.
Not sure how this got corrupted, fix incoming
…inx-tribes into startup-modal-polish
|
Not sure how to fix the Prettier check... |
if you run |
|
also just as a future heads up screenshots really help out the review process to help any reviews understand what exactly is being added/modified |
|
prettier failure addressed in 3e21f6b |
AbdulWahab3181
pushed a commit
to AbdulWahab3181/sphinx-tribes
that referenced
this pull request
Jan 26, 2024
* added separate QR code step to the startup sequence * fixed text clipping and centered qr code * fixed text clipping and centered qr code * intermediate merge fix * merage fix * fix connection check * fix: prettier --------- Co-authored-by: kevkevin <oapallikunnel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added separate qr code step, fixed alignment issues from last pr.
Issue ticket number and link
Closes #813
Checklist before requesting a review