Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bounty): fixes the copy button to correctly copy the bounty url o… #906

Merged
merged 3 commits into from
Nov 9, 2023
Merged

fix(bounty): fixes the copy button to correctly copy the bounty url o… #906

merged 3 commits into from
Nov 9, 2023

Conversation

dylanbathurst
Copy link
Contributor

…n both web and mobile, also fixes a case where bounty url was showing undefined, cleans up some unused code

Describe your changes

Fixes the copy to clipboard button text by setting the proper bounty path /bounty/${id} and cleaning up some code that wasn't being used anywhere.
https://www.loom.com/share/d8e612468b8040c3aa85516b41690d4a

Issue ticket number and link

https://community.sphinx.chat/bounty/656

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@dylanbathurst
fix(bounty): fixes the copy button to correctly copy the bounty url o…
0e383b9 
…n both web and mobile, also fixes a case where bounty url was showing undefined, cleans up some unused code
@dylanbathurst
chore: this commit fixes stakwork#884
2933f12
@dylanbathurst dylanbathurst mentioned this pull request Nov 8, 2023
Closed
3 tasks
kevkevinpal
kevkevinpal reviewed Nov 8, 2023
View reviewed changes
frontend/app/src/config/host.ts Outdated Show resolved Hide resolved
frontend/app/src/config/ModeDispatcher.tsx Outdated Show resolved Hide resolved
@elraphty
Copy link
Contributor

elraphty commented Nov 9, 2023

@kevkevinpal, It looks good to me.

@kevkevinpal
Copy link
Contributor

looking good to me will merge when the gitactions are passing!

@kevkevinpal kevkevinpal merged commit b86f545 into stakwork:master Nov 9, 2023
4 checks passed
@kevkevinpal
Copy link
Contributor

Welcome as a new contributor!! 🎉 @dylanbathurst

elraphty pushed a commit that referenced this pull request Jan 26, 2024
@dylanbathurst
fix(bounty): fixes the copy button to correctly copy the bounty url o… (
be8d466 
#906)

* fix(bounty): fixes the copy button to correctly copy the bounty url on both web and mobile, also fixes a case where bounty url was showing undefined, cleans up some unused code

* chore: this commit fixes #884

* chore: reset configs back to normal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevkevinpal kevkevinpal kevkevinpal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanbathurst @elraphty @kevkevinpal