initial jest testing #924
Merged
initial jest testing #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elraphty
pushed a commit
that referenced
this pull request
Jan 26, 2024
* initial jest testing * add to git actions * testing to see if this fixes our craco tests * testing to see if this fixes our craco tests * fix exports of helpers * added configs for both jest and craco to use * seperated workflows and renamed them to be clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In this change I'm adding some jest testing to start adding automated testing into this project starting with unit tests
I've separated out the craco test configs and jest configs into two different files so they do not interfere with each other,
right now we have some tests using craco tests but it does not provide test coverage which we will need in the future.
I also moved the satsToUsd helper file and make an extended helper file because it used uiStore which jest did not like
This change also fixes the git action names and makes it easier for the PR review to know which each test is doing
Issue ticket number and link
not sure but we might have a test issue related
Type of change
CI/CD
Checklist before requesting a review