Derive Clone for mail_send::smtp::message::{Message, Address, Parameters, Parameter}. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
SmtpClient::sendtakesimpl IntoMessageas an argument, thus it takes ownership of a message and in times when message sending fails and it is necessary to retry sending the same message a bit later, it is not possible to do so, because it has been moved.This is why we #[derive(Clone)] for Message, Address, Parameters, Parameter.
Now it is possible to clone message before sending it. On success we can drop the original, on retry cases we can clone original again, update some parameters and resend.