Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stamp Detail page - sharing #488

Open
babalicious-io opened this issue Dec 11, 2024 · 4 comments
Open

Stamp Detail page - sharing #488

babalicious-io opened this issue Dec 11, 2024 · 4 comments

Comments

@babalicious-io
Copy link
Collaborator

Screenshot 2024-12-11 at 22 47 02

The copy/share iconButtons on the Stamp Detail page use a strange url string - that i don't think is valid

Take this page:
https://dev.bitcoinstamps.xyz/stamp/a469bacec0e9901960cb75e371c52a3a39a3ec8b931e595d84ec1062a6a19ac2

copy = https://stampchain.io/stamp/807211
this is the same url used in "share on X"
Screenshot 2024-12-11 at 22 38 02

the url gives an error404
Screenshot 2024-12-11 at 22 51 18


I changed the code to use CPID and devSiteUrl instead of stamp# and stampchain.io, this made the websiteCard display in shareOnXcard - albeit without image

Screenshot 2024-12-11 at 22 28 04

I tried adding https://dev.bitcoinstamps.xyz/s/a469bacec0e9901960cb75e371c52a3a39a3ec8b931e595d84ec1062a6a19ac2 for stamp image, but the XShareCard doesn't display it
Claude gave several suggestions to fix it and but kept returning to the question if there are CORS headers or other restrictions on the image endpoint that might prevent Twitter from accessing it...


Will the url be valid once site is moved to stampchain.io and will the image then be fetched automatically ?

@babalicious-io
Copy link
Collaborator Author

There may also be an issue with svg/gif/html stamp image previews
Think there has to be some magic convert2png type thing happening

f this is implemented we can also have a download stamp icon on the StampDetail page for users to download an image
Can even insert the images into cards for sharing
Screenshot 2024-12-11 at 23 29 35

@reinamora137
Copy link
Contributor

reinamora137 commented Dec 11, 2024

This won’t work until we go live into stampchain but https://bitcoinstamps.xyz/stamp/807211 is a valid url for them

@reinamora137
Copy link
Contributor

The image display thing has to do with the Head tag rewrite on the detail page. I don’t think that’s setup properly yet

Copy link

devin-ai-integration bot commented Dec 18, 2024

fix(sharing): resolve stamp detail sharing URL and Twitter card issues

Current issues:

  1. Invalid URL format: Using stamp number (807211) instead of CPID in share/copy URLs
  2. Twitter card not displaying properly
  3. Image loading issues possibly due to CORS restrictions

Required fixes:
1.
2. Ensure proper Twitter card meta tags are present in the page
3. Configure CORS headers for image endpoints to allow Twitter's crawler
4. Update URL structure to match the production domain pattern

Note: The URL format will need to be aligned with the production domain (stampchain.io) structure to ensure consistent behavior across environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants