Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a warning when user provides RDump input files #1177

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Show a warning when user provides RDump input files #1177

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bb46ee
Show a warning when user provides RDump input files
WardBrian Aug 9, 2023
9323747
Merge commit '508b7c3e8b308e20960579310175faf376c438e4' into HEAD
yashikno Aug 9, 2023
011de60
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/cmdstan/command_helper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@ inline shared_context_ptr get_var_context(const std::string &file) {
stan::json::json_data var_context(stream);
return std::make_shared<stan::json::json_data>(var_context);
}
std::cerr
<< "Warning: file '" << file
<< "' is being read as an 'RDump' file.\n"
"\tThis format is deprecated and will not receive new features.\n"
"\tConsider saving your data in JSON format instead."
<< std::endl;
stan::io::dump var_context(stream);
return std::make_shared<stan::io::dump>(var_context);
}
Expand Down Expand Up @@ -220,6 +226,14 @@ context_vector get_vec_var_context(const std::string &file, size_t num_chains) {
msg << "file ending of " << file_ending << " is not supported by cmdstan";
throw std::invalid_argument(msg.str());
}
if (file_ending != ".json") {
std::cerr
<< "Warning: file '" << file
<< "' is being read as an 'RDump' file.\n"
"\tThis format is deprecated and will not receive new features.\n"
"\tConsider saving your data in JSON format instead."
<< std::endl;
}
std::string file_1
= std::string(file_name + "_" + std::to_string(1) + file_ending);
std::fstream stream_1(file_1.c_str(), std::fstream::in);
Expand Down Expand Up @@ -262,6 +276,12 @@ context_vector get_vec_var_context(const std::string &file, size_t num_chains) {
}
}
// This should not happen
std::cerr
<< "Warning: file '" << file
<< "' is being read as an 'RDump' file.\n"
"\tThis format is deprecated and will not receive new features.\n"
"\tConsider saving your data in JSON format instead."
<< std::endl;
using stan::io::dump;
std::fstream stream(file.c_str(), std::fstream::in);
return context_vector(num_chains, std::make_shared<dump>(dump(stream)));
Expand Down