Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stan/math/prim/scal/prob/neg_binomial_lccdf.hpp more efficient #595

Closed
syclik opened this issue Aug 1, 2017 · 0 comments · Fixed by #1663
Closed

Make stan/math/prim/scal/prob/neg_binomial_lccdf.hpp more efficient #595

syclik opened this issue Aug 1, 2017 · 0 comments · Fixed by #1663
Labels
code cleanup
Milestone
3.2.0

Comments

@syclik
Copy link
Member

syclik commented Aug 1, 2017

Summary:

There are terms that are being computed multiple times and we should be using inv(x) instead of 1 / x.

See @bob-carpenter's comment

Current Version:

v2.16.0
@syclik syclik mentioned this issue Aug 1, 2017
Merged
3 tasks
@andrjohns andrjohns mentioned this issue Sep 24, 2017
Merged
3 tasks
bob-carpenter pushed a commit that referenced this issue Sep 27, 2017
Merge pull request #626 from andrjohns/develop
c67762a 
Replace 1/x with inv(x) - issue #595
@mcol mcol mentioned this issue Jan 31, 2020
Merged
5 tasks
@mcol mcol added this to the 3.1.0++ milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

correctness fixes in neg_binomial_* functions stan-dev/math
2 participants
@syclik @mcol