-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang tidy cleanup and using std algorithms #1373
Changes from all commits
b9f545b
4064902
23706ed
bade075
8a2dff8
2407b7a
8bb5458
0c31b37
d68129f
f9275d1
06c465a
bdadd8e
8656836
d716461
3266349
90be53e
c9fef6c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,11 @@ class accumulator { | |
/** | ||
* Destroy an accumulator. | ||
*/ | ||
~accumulator() {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there a reason for defining the accumulator destructor as empty here? tmk this still calls the destructor for all the accumulates members There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is OK to leave as default---as is, it's not virtual and breaks the rule of 3(5). |
||
~accumulator() = default; | ||
accumulator(const accumulator& other) = default; | ||
accumulator(accumulator&& other) = default; | ||
accumulator& operator=(const accumulator& other) = default; | ||
accumulator& operator=(accumulator&& other) = default; | ||
|
||
/** | ||
* Add the specified arithmetic type value to the buffer after | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very neat!