Use unambiguous size function with old rstan #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsbadr sorry to double-ping, but would you be able to merge this and create a new StanHeaders release when you get a minute? |
hsbadr
reviewed
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hsbadr
When using c++17 with rstan 2.21 & StanHeaders 2.26 we run into the same ambiguity errors with the
size()function - because the olderstancis emittingsize()without the math qualifier. We can workaround this by using the "old" size function with rstan 2.21, which has less general templating and doesn't result in the same ambiguity errorsEDIT: This will be needed for the
blavaanpackage