-
-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
row/col stochastic matrix for deserializer and serializer #3298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor thing but looks good! I appreciate the clean up of the deserializer test
src/stan/io/deserializer.hpp
Outdated
inline auto read_constrain_stochastic_row(LP& lp, Eigen::Index rows, | ||
Eigen::Index cols) { | ||
using stan::math::stochastic_row_constrain; | ||
if (Jacobian) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is already an overload in math which checks the template param, can we call that one for consistency? (same for column above)
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
7647dc5
to
d26e7b9
Compare
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
Adds the serializer and deserializer functions for those constraints
Intended Effect
Used upstream by compiler for code gen
How to Verify
Side Effects
Documentation
Docs for functions added
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: