-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] Document tenants:up
and tenants:down
commands
#214
Comments
No idea about that comment. Can you open the file in the repo and click on "Blame" to find which commit added that? |
Here's the commit: stein-j/tenancy@b97f409#diff-9139503e6a6ae12909d9516b90ec1980dcf11275373d8e50ad0872df32f36c0bR42-R44 EDIT: and here's the squashed PR commit archtechx/tenancy@121370e |
Ah I see, I first thought this is related to migrations (I was reading this on mobile) but this is the maintenance mode. I see what he meant there. By default, Laravel stores maintenance mode details in a file (somewhere in Perhaps @stein-j could explain what exact features are not available? Maybe we discussed this in the original PR that I closed, so @lukinovec you could try checking there. |
I must say, my comment is not very helpful, I don't even remember what I meant by "The base down command is heavily used." Okay, from what I remember there are two things:
|
Thank you for the info, I checked out the PR that adds the commands, and it seems the only discussed limitations are the ones you mention here. Related comments: |
Updated the documentation @stancl |
I've just made a PR so implement tenancy maintenance mode drivers: archtechx/tenancy#967. Note: This doesn't uses the same config parameter Laravel has two drivers I know you just changed the documentation, if this PR is merged you'll need to update it again 😆 |
Regarding what @stein-j wrote #214 (comment), I think the first issue is fine because the maintenance mode is tenant-specific. And the second issue I addressed in the PR — it's probably not pursuing. So this looks good now |
I wrote docs for the new Up/Down commands. @stancl, there are comments in the Down command saying some Laravel features are not available with tenants because of storing the data in the tenant database. I think we should document that, but what exactly are the limitations?
EDIT: updated to include info from this comment
The documentation:
Maintenance mode commands (tenant-aware)
This package provides commands for putting tenants into maintenance mode (
tenants:down
), and out of maintenance mode (tenants:up
).Tenant databases are used for storing maintenance mode information (
maintenance_mode
in tenant'sdata
column). This cannot be changed by setting the driver using theapp.maintenance.driver
config key.The
tenants:down
command accepts the same options as Laravel'sdown
command, except for--render
.Visit the Laravel documentation for more information about maintenance mode with the mentioned limitations in mind.
The text was updated successfully, but these errors were encountered: