Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 12.0.0 #123

Closed
4 of 7 tasks
voxpelli opened this issue Jun 27, 2018 · 16 comments
Closed
4 of 7 tasks

Release 12.0.0 #123

voxpelli opened this issue Jun 27, 2018 · 16 comments

Comments

@voxpelli
Copy link
Member

voxpelli commented Jun 27, 2018

As ESLint 5.0.0 is now released it would be neat to get eslint-config-standard 12.0.0 released as well.

Some stuff should probably be done first though:

Required:

  • Change peerDependency to require the stable version
  • (anything else?)

Nice to have:

@StarpTech
Copy link

Does the PR consider also this issue when using eslint 5?

(node:12988) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "standard")

@LinusU
Copy link
Member

LinusU commented Jun 30, 2018

Would be great to get in #124 as well

@yuchonghua
Copy link

image

@voxpelli
Copy link
Member Author

@StarpTech @yuchonghua That should already be fixed in the alpha release of this module, see #117 and 6a89a51, please try that one

@voxpelli
Copy link
Member Author

@LinusU Added that to the list, is a review by @feross or such needed for that to be merged?

@yuchonghua
Copy link

When will it be released?
@voxpelli @LinusU

@js-yezi
Copy link

js-yezi commented Jul 16, 2018

678c45402d16ca06a16e8ef2ff57a25a

@voxpelli
Copy link
Member Author

I guess that #126 should be merged as well before 12.0.0 is released, so that the module is as up to date as possible

@AllenZho
Copy link

It seems that all the upgrades with eslint5 are stuck here. Can it be solved as soon as possible? It doesn't have to be solved in the 12.0.0 release, you can solve it at 11.0.0+ first.
/ping @voxpelli @Greenkeeper[bot]

@voxpelli
Copy link
Member Author

@AllenZho See #123 (comment) – ESLint 5 is as far as I understand already supported by the released 12.0.0-alpha.0 and everyone who needs to be able to use ESLint 5 right here and now, and wants to do so without any warnings, can use that version.

Regarding when a stable 12.0.0 can be released – I don't know – I'm not a maintainer – I just opened this issue to help move it along. The only blocker from releasing a stable 12.0.0 is an action from a maintainer – all things outlined in this issue are just extra nice to haves that would be good, but not essential, to get included

@voxpelli
Copy link
Member Author

@LinusU Any feedback on what/who we are waiting on to get this moving? Is it @feross that needs to find time for this or are there some topics that needs further feedback and/or work? And if so: Is there something one can do to help there

@LinusU
Copy link
Member

LinusU commented Jul 31, 2018

From my side, I'm mostly waiting on @feross.

I would be very happy to move forward with this, but I'm not sure if we have the release process documented somewhere, and I'm not sure if I'm added on npm 🤔

Would be great if you would want to give me some quick directions @feross ☺️ could be anything from "I'll have time soon, please wait" to "added you on npm, please go ahead" ❤️

@macklinu
Copy link

I just published eslint-plugin-promise@v4, which supports ESLint v5 (drops support for Node v4). Not sure if that's on your list, but eslint-plugin-promise should no longer block this, if so. 👍

@voxpelli
Copy link
Member Author

@macklinu Great! I added it to the list 👍

@feross
Copy link
Member

feross commented Aug 28, 2018

Thank you to everyone who commented on this issue! ❤️ Especially to @voxpelli and @LinusU for pushing things along.

I'm working to release standard 12 by tonight. Stay tuned!

(And I plan to documenting the release process and get a few others up to speed so I'm not a bottleneck in the future.)

@feross
Copy link
Member

feross commented Aug 28, 2018

eslint-config-standard@12.0.0 is released!

@feross feross closed this as completed Aug 28, 2018
clarkdo added a commit to nuxt/nuxt that referenced this issue Aug 31, 2018
- [ ] babel-eslint babel/babel-eslint#664
- [x] eslint-config-standard-jsx standard/eslint-config-standard-jsx#32
- [x] eslint-config-standard to be stable release standard/eslint-config-standard#123
- [x] eslint-plugin-html
- [x] eslint-plugin-import
- [x] eslint-plugin-jest
- [x] eslint-plugin-node
- [x] eslint-plugin-promise
- [x] eslint-plugin-standard standard/eslint-plugin-standard#29
- [x] eslint-plugin-vue vuejs/eslint-plugin-vue#504
- [x] eslint-plugin-react https://github.com/yannickcr/eslint-plugin-react/releases/tag/v7.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

8 participants