disable BulkChangeTable cop #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this cop can offer faster migrations for very large databases, it also leads to more complex, more error-prone, and less understandable migrations for smaller (most) projects. For example, `change_table` with `bulk: true` does not properly reverse migrations that add columns and indices on those columns. The columns are dropped first and it then attempts to drop the indices, which were automatically dropped when the columns were dropped, resulting in an error. Furthermore, this situation is harder to debug with `bulk: true` as the standard rails migration logging just logs `change_table(:bulk=>true)`, not the individual columns and indices being added/dropped. Finally, it only alerts on a subset of alter table statements, allowing some to be outside a `change_table` but forcing others to be inside the `change_table` block.
|
That does indeed seem bad! |
Cohen-Carlisle
force-pushed
the
disable-bulk-change-table-cop
branch
from
f0b1f59
to
68ccc3b
Compare
|
Wow, that was quick! I spotted a typo in my commit message and amended it (hence the force push). I just barely got it in 😉 Thanks for the fast response and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this cop can offer faster migrations for very large databases, it also leads to more complex, more error-prone, and less understandable migrations for smaller (most) projects. For example,
change_tablewithbulk: truedoes not properly reverse migrations that add columns and indices on those columns. The columns are dropped first and it then attempts to drop the indices, which were automatically dropped when the columns were dropped, resulting in an error. Furthermore, this situation is harder to debug withbulk: trueas the standard rails migration logging just logschange_table(:bulk=>true), not the individual columns and indices being added/dropped. Finally, it only alerts on a subset of alter table statements, allowing some to be outside achange_tablebut forcing others to be inside thechange_tableblock.