Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exit code for version and help runners #272

Merged
merged 2 commits into from
Mar 6, 2021
Merged

Fix exit code for version and help runners #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
989b84c
Test --version and --help CLI flags
adam12 Mar 6, 2021
d661ac0
Cast runner return value to Integer
adam12 Mar 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/standard/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def initialize(argv)

def run
config = @builds_config.call(@argv)
@loads_runner.call(config.runner).call(config)
@loads_runner.call(config.runner).call(config).to_i
end
end
end
20 changes: 20 additions & 0 deletions test/standard/cli_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,24 @@ def test_unfixable_manually_fixed
assert_empty fake_err.string
assert_empty fake_out.string
end

def test_version
fake_out, fake_err, exit_code = do_with_fake_io {
Standard::Cli.new(["--version"]).run
}

assert_equal 0, exit_code
assert_empty fake_err.string
refute_empty fake_out.string
end

def test_help
fake_out, fake_err, exit_code = do_with_fake_io {
Standard::Cli.new(["--help"]).run
}

assert_equal 0, exit_code
assert_empty fake_err.string
refute_empty fake_out.string
end
end