Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent dictionary access bugs #1

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kimrypstra
Copy link

@kimrypstra kimrypstra commented Oct 22, 2023

Note
Not ready to merge, still testing

Changes

We've had some issues that seem to be related to concurrent access of the DependencyResolver.sharedInstances dictionary. So I changed DependencyResolver to an actor as it's designed to regulate access to shared state.

After increasing the deployment target to iOS 13, tests no longer ran due to the removal of a dependency inside Nimble. So I also bumped Nimble and Quick, and fixed the tests.

Copy link
Owner

@stanfeldman stanfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants