Bring the TLE backend to parity with the current stapi-spec #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The passes object will now pull the datetime from the original request. Furthermore, it inherits the correct base model. Lastly, the shape of the opportunity class now matches what the validator expects.
…alculate the range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fixup the TLE backend so the opportunities endpoint returns values successfully.
The specific changes include updating the
PassPropertiesmodel to inherit from the correct base class, hoisting some properties from the request, addingprodut_idto the response, and generally providing a shape that will pass validation.