Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): update huggingface dataset string/binary convert logical #2498

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

tianweidut
Copy link
Member

Description

  • update hash digest size: 64 -> 32
  • update text_cls_AG_NEWS dataset to use starwhale.Text type
  • update huggingface dataset string/binary convert logical

Modules

  • Client
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #2498 (c8a3796) into main (a7c9a28) will increase coverage by 7.71%.
The diff coverage is 93.33%.

@@             Coverage Diff              @@
##               main    #2498      +/-   ##
============================================
+ Coverage     83.53%   91.24%   +7.71%     
============================================
  Files           438      102     -336     
  Lines         23962    11780   -12182     
  Branches       1417        0    -1417     
============================================
- Hits          20017    10749    -9268     
+ Misses         3310     1031    -2279     
+ Partials        635        0     -635     
Flag Coverage Δ
console ?
controller ?
standalone 91.24% <93.33%> (+0.07%) ⬆️
unittests 91.24% <93.33%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/view.py 66.47% <66.66%> (-0.20%) ⬇️
...ient/starwhale/integrations/huggingface/dataset.py 98.68% <100.00%> (+0.09%) ⬆️
client/starwhale/utils/fs.py 88.41% <100.00%> (+1.29%) ⬆️

... and 339 files with indirect coverage changes

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit e450b17 into star-whale:main Jul 12, 2023
38 checks passed
@tianweidut tianweidut deleted the feat/text branch September 5, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants