Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): refine the exposed links #2504

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jul 14, 2023

Description

cc @xuchuan

exposedlinks.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #2504 (8476a6a) into main (c924313) will decrease coverage by 7.43%.
The diff coverage is 70.58%.

@@             Coverage Diff              @@
##               main    #2504      +/-   ##
============================================
- Coverage     83.57%   76.15%   -7.43%     
- Complexity     2606     2609       +3     
============================================
  Files           438      336     -102     
  Lines         23974    12111   -11863     
  Branches       1417     1404      -13     
============================================
- Hits          20037     9223   -10814     
+ Misses         3303     2254    -1049     
  Partials        634      634              
Flag Coverage Δ
console ?
controller 76.15% <70.58%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/ai/starwhale/mlops/api/protocol/job/JobVo.java 20.00% <ø> (ø)
...whale/mlops/domain/job/converter/JobConverter.java 62.13% <64.28%> (-0.87%) ⬇️
...i/starwhale/mlops/domain/job/step/ExposedType.java 100.00% <100.00%> (ø)

... and 105 files with indirect coverage changes

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 11a2637 into star-whale:main Jul 14, 2023
17 checks passed
@jialeicui jialeicui deleted the expose-detail branch July 14, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants