Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): runtime build does not dump pip and conda configs by default #2601

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Aug 7, 2023

Description

The Starwhale server already supports system-level pip and conda configuration files. Starwhale Cloud also provides a fast internal mirror for pip and conda packages. Therefore, by default swcli does not copy local user configurations when building the runtime environment.

Modules

  • Client

Checklist

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2601 (4bdedf5) into main (a131af6) will increase coverage by 8.96%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2601      +/-   ##
============================================
+ Coverage     82.60%   91.56%   +8.96%     
============================================
  Files           456      104     -352     
  Lines         24890    11966   -12924     
  Branches       1509        0    -1509     
============================================
- Hits          20560    10957    -9603     
+ Misses         3663     1009    -2654     
+ Partials        667        0     -667     
Flag Coverage Δ
console ?
controller ?
standalone 91.56% <100.00%> (+0.01%) ⬆️
unittests 91.56% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/starwhale/core/runtime/view.py 87.43% <ø> (ø)
client/starwhale/core/runtime/model.py 93.75% <100.00%> (ø)
client/starwhale/utils/venv.py 85.68% <100.00%> (-0.69%) ⬇️

... and 354 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 974be24 into star-whale:main Aug 7, 2023
38 checks passed
@tianweidut tianweidut deleted the chore/runtime-build-emit branch September 5, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants