Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): disable task succeed status for delay case #2603

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Aug 8, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui August 8, 2023 02:47
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2603 (52136dc) into main (974be24) will decrease coverage by 2.87%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2603      +/-   ##
============================================
- Coverage     82.62%   79.76%   -2.87%     
============================================
  Files           456        1     -455     
  Lines         24890       84   -24806     
  Branches       1509       14    -1495     
============================================
- Hits          20565       67   -20498     
+ Misses         3658       17    -3641     
+ Partials        667        0     -667     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 455 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit a68f55d into star-whale:main Aug 8, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants