Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): report revert error #2615

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 11, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Aug 11, 2023
@jialeicui
Copy link
Contributor

cc @lijing-susan

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2615 (0c1d8e9) into main (34eac83) will decrease coverage by 8.39%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2615      +/-   ##
============================================
- Coverage     82.26%   73.88%   -8.39%     
  Complexity     2759     2759              
============================================
  Files           478      373     -105     
  Lines         25495    13388   -12107     
  Branches       1547     1533      -14     
============================================
- Hits          20974     9892   -11082     
+ Misses         3834     2808    -1026     
- Partials        687      688       +1     
Flag Coverage Δ
console ?
controller 73.88% <ø> (-0.02%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...whale/mlops/domain/report/mapper/ReportMapper.java 82.60% <ø> (ø)

... and 106 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 3f92e91 into star-whale:main Aug 11, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants