Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): refactor model/dataset/runtime list for server and cloud instance #2625

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Aug 15, 2023

Description

asciicast

Modules

  • Client
  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2625 (437d1b4) into main (9a18a95) will increase coverage by 0.04%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##             main    #2625      +/-   ##
==========================================
+ Coverage   91.47%   91.51%   +0.04%     
==========================================
  Files         105      104       -1     
  Lines       12107    12040      -67     
  Branches       14        0      -14     
==========================================
- Hits        11075    11019      -56     
+ Misses       1032     1021      -11     
Flag Coverage Δ
console ?
standalone 91.51% <94.28%> (-0.04%) ⬇️
unittests 91.51% <94.28%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/starwhale/core/dataset/view.py 69.18% <ø> (ø)
client/starwhale/base/view.py 85.02% <91.66%> (+0.44%) ⬆️
client/starwhale/base/cloud.py 83.05% <95.65%> (-2.50%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 8c61f28 into star-whale:main Aug 16, 2023
42 checks passed
@tianweidut tianweidut deleted the bug/fix-list branch September 5, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants