Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize(console): grid with extensive columns resulting in prolonged response times #3114

Merged
merged 11 commits into from
Jan 5, 2024

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Jan 5, 2024

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6a498b) 82.71% compared to head (a35f22c) 72.09%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3114       +/-   ##
=============================================
- Coverage     82.71%   72.09%   -10.62%     
=============================================
  Files           575        3      -572     
  Lines         32088      215    -31873     
  Branches       1865       61     -1804     
=============================================
- Hits          26540      155    -26385     
+ Misses         4723       58     -4665     
+ Partials        825        2      -823     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller ?
standalone ?
unittests 72.09% <ø> (-19.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 554441f into star-whale:main Jan 5, 2024
17 checks passed
@jialeicui jialeicui added the console 🎨 console label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants