Add support for incremental models #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
commented
Sep 30, 2021
hovaesco
reviewed
Oct 1, 2021
hovaesco
reviewed
Oct 1, 2021
hovaesco
reviewed
Oct 1, 2021
|
Looks good, some initial comments, I will test it later |
findinpath
force-pushed
the
feature/incremental-append
branch
from
8011356 to
406eea4
Compare
|
I tested it and it works nice. One question, is temp table |
findinpath
force-pushed
the
feature/incremental-append
branch
2 times, most recently
from
294430f to
74bd613
Compare
|
@hovaesco thanks for raising this comment : #10 (comment) i've added handling for deleting the temporary table in case of appending new content. |
findinpath
force-pushed
the
feature/incremental-append
branch
3 times, most recently
from
e026e19 to
6fda13a
Compare
hovaesco
reviewed
Oct 5, 2021
The incremental strategy supported is to insert new records into target table, without updating or overwriting. Resolves: #1
findinpath
force-pushed
the
feature/incremental-append
branch
from
6fda13a to
36b6c85
Compare
EminUZUN
pushed a commit
to EminUZUN/dbt-trino
that referenced
this pull request
Feb 14, 2023
…ental-append Add support for incremental models
damian3031
pushed a commit
to damian3031/dbt-trino
that referenced
this pull request
Sep 9, 2024
…ental-append Add support for incremental models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incremental strategy supported is to insert new records into target table,
without updating or overwriting.
Resolves: #1