-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Upgrade to Metabase 1.49.3 and fix the tests accordingly
- Loading branch information
Showing
9 changed files
with
482 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"trino": "431", | ||
"clojure": "1.11.1.1262", | ||
"metabase": "v1.48.3" | ||
"metabase": "v1.49.3" | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
(ns metabase.test.data.dataset-definition-test | ||
(:require | ||
[clojure.test :refer :all] | ||
[metabase.driver :as driver] | ||
[metabase.driver.ddl.interface :as ddl.i] | ||
[metabase.test :as mt] | ||
[toucan2.core :as t2])) | ||
|
||
(deftest dataset-with-custom-pk-test | ||
(mt/test-drivers (disj (mt/sql-jdbc-drivers) | ||
;; presto doesn't create PK for test data :) not sure why | ||
:presto-jdbc | ||
;; creating db for athena is expensive and require some extra steps, | ||
;; so it's not worth testing against, see [[metabase.test.data.athena/*allow-database-creation*]] | ||
:athena | ||
;; there is no PK in sparksql | ||
:sparksql))) | ||
|
||
(deftest dataset-with-custom-composite-pk-test | ||
(mt/test-drivers (disj (mt/sql-jdbc-drivers) | ||
;; presto doesn't create PK for test data :) not sure why | ||
:presto-jdbc | ||
;; creating db for athena is expensive and require some extra steps, | ||
;; so it's not worth testing against, see [[metabase.test.data.athena/*allow-database-creation*]] | ||
:athena | ||
;; there is no PK in sparksql | ||
:sparksql))) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters