-
Notifications
You must be signed in to change notification settings - Fork 495
Add a web3 erc20 example for StarknetJS #223
Conversation
Please your review @l-henri @omarespejel. Contribution to #194 |
Hello @devnet0x help solve prettier issue npm i
npm run format |
Done, please your review @dalmasonto thanks |
Hello @devnet0x seems it didn't work, there are two files having some style problems, hope you did run |
Sorry @dalmasonto , please check again |
Still you have same error, that is code style formatting error, that is why "all checks have failed" from above. I have made a quick fork of your repo and created a PR for the same devnet0x#1, I have formatted the docs their, just check it out, if your work is all there you can merge and see whether the above checks pass that is the prettier format checks |
done |
Thanks, @devnet0x! Your updates are clear and I'm ready to merge them. Please address the conflict in the foundry forge chapter, as your well-formatted PR clashes with its previous state which was badly formatted. Appreciate the review, @dalmasonto! |
updated and now all check passed, please could you check @dalmasonto @omarespejel ? |
Hey @devnet0x, this is amazing! Thank you for pushing the subchapter! Also thanks for the reordering! Thank you @dalmasonto for the review |
Also move previous starknet react examples under starknet-react title