-
Notifications
You must be signed in to change notification settings - Fork 495
Forces linter check before commit #224
Forces linter check before commit #224
Conversation
Please review @omarespejel |
Hey @ccolorado, This is truly valuable, thank you! Before merging, could you clarify: What steps do contributors need to follow to comply with this new process? The simpler the better. We want to ensure it's straightforward for them to contribute to the Book. |
After husky is installed and prepared ( Users can opt out of this helper by: |
Hello @ccolorado seems prettier failed on your side too, kindly run npm i
npm run format That way prettier problems will be evaded |
Yeah I notice it failed on CI, but wierdly "works on my machine". |
It will work locally but that does not pass when you push to github since it will try run its checks. Some files might be having issues within the code you pushed. Just formatting issues ie |
Thanks, @ccolorado! Your explanation clarified everything for me. Could you address the conflict in the foundry forge chapter update? It is because the chapter was badly formatted and we recently updated it, it is not fault of your PR. That would be all. And a big thanks to @dalmasonto for the review! |
Hey @ccolorado! Thank you for your contribution. Anything that makes the Book work and look better is very important! let me know if you want to contribute further, I know your abilities! |
* Adds pre-commit hook to force running linter * Refactor pre-commit hoock * Update to main + lint run --------- Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
Forces linter (npx prettier) check to pass before git commit
Requires installation
$ npm install && npm run prepare
more options for npm and yarn @
https://typicode.github.io/husky/getting-started.html