Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

[i18n]Translation/zh-cn 1019 #225

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

cryptonerdcn
Copy link
Contributor

This pr also fixed this bug: #214 (comment)
@omarespejel Can you review this? Thanks!

@dalmasonto
Copy link
Contributor

Seems prettier is failing, kindly run prettier locally before pushing your code ie
npm i
then npm run format This can help with the prettier issue

@cryptonerdcn
Copy link
Contributor Author

cryptonerdcn commented Oct 21, 2023

Seems prettier is failing, kindly run prettier locally before pushing your code ie npm i then npm run format This can help with the prettier issue

Thank you but I don't think an i18n PR should do this.
An i18n PR means it should only change the .po file, it should not change the original .md file, which also means
the reason why prettier is failing is not caused by the PR.
I think the right way to fix this problem is rebase this PR to the latest main branch(which passed the prettier). I will do it as soon as the main branch merges your PR.

@dalmasonto
Copy link
Contributor

The prettier format is not caused by this PR, but rather some files within your branch that are not properly formatted.
image
The above two files were not formatted correctly before being pushed and with npm run format that could be fixed since nothing really changes except adding the missing spaces within those two files.

@omarespejel omarespejel merged commit 9cd0e0b into starknet-edu:main Oct 23, 2023
1 check failed
@omarespejel
Copy link
Collaborator

Thanks, @cryptonerdcn for the translation and @dalmasonto for reviewing!

I'm seeking advice from both @Nadai2010 and @cryptonerdcn: How should we handle translations when updating content?

@cryptonerdcn
Copy link
Contributor Author

Thanks, @cryptonerdcn for the translation and @dalmasonto for reviewing!

I'm seeking advice from both @Nadai2010 and @cryptonerdcn: How should we handle translations when updating content?

Thanks @omarespejel ! It is a little hard to follow every PR for new content because there are always not enough translators. But in Cairo Book, we update the translations once every 1 or 2 weeks, and it works fine.

@Nadai2010
Copy link
Contributor

Good morning, I have noticed that when they make some changes, sometimes complete links are broken, both in Spanish translations and I suppose in Chinese, I think that when updates are made sometimes it is not reflected well in the messenger.pot or some links are changed, without However, in other files the flow in poedit with the missing changes in the translation is well detected.

We can @cryptonerdcn go around the group and notify us of the updates for the translations, do you think? It will depend on the translators but if they need an update every 1-2 weeks, I see it well

imgbot bot pushed a commit to hardiktheprogrammer/starknetbook that referenced this pull request Jan 28, 2024
* translation: update to 2.11

* translation: finish chapter 2.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants