Starknet foundry snforge updated

[Akinbola247]

hi, @omarespejel In reference to this issue #219 , i have updated the chapter as per request. Kindly review this and give a feedback. You can also take a look at the code reference used in computing the chapter here https://github.com/Akinbola247/ERC20-Starknet-Foundry

[dalmasonto]

Hello @Akinbola247, seems like prettier is failing to run. Kindly update your source code, install the js dependencies and run the prettier command from package json file then push again

[Akinbola247]

Hello @Akinbola247, seems like prettier is failing to run. Kindly update your source code, install the js dependencies and run the prettier command from package json file then push again

apparently the issue came from a commit from src/ch04-01-accounts.md that i pulled into my local machine

[dalmasonto]

Okay, have you tried running the linter locally?

[Akinbola247]

I've fixed it. Thanks for calling my attention to it @dalmasonto

[dalmasonto]

Welcome, it has worked as expected!

[omarespejel]

hey @Akinbola247! Thank you for the PR! I merged it and will review and edit it ASAP and come back with feedback if there is any.

Also thank you @dalmasonto for reviewing 🙏

[omarespejel]

Hi @Akinbola247,

I've reviewed your contribution and made some formatting edits. It's looking nice! Just a couple of final touches are needed:

• Could you embed links to references within the chapter? This would enable students to delve deeper into the topics. For instance, a link to documentation on fuzz tests or other cheat codes would be beneficial.
• a brief summary at the end highlighting key takeaways would be a great addition.

Thank you once more!

[Akinbola247]

Hi @Akinbola247,

I've reviewed your contribution and made some formatting edits. It's looking nice! Just a couple of final touches are needed:

• Could you embed links to references within the chapter? This would enable students to delve deeper into the topics. For instance, a link to documentation on fuzz tests or other cheat codes would be beneficial.
• a brief summary at the end highlighting key takeaways would be a great addition.

Thank you once more!

Sure! @omarespejel. Thanks for the review, I’ll get it done right away.

[omarespejel]

Thanks, @Akinbola247! Note I've made edits to the chapter. Ensure you 'git pull' to see the updates before your next PR.

[Akinbola247]

hey @omarespejel an observation here https://book.starknet.io/ch02-12-foundry-forge.html
a code snippet in the "Full erc20 test example file" is outside the code section box. I sent you a screenshot on telegram.

[Akinbola247]

hi @omarespejel i've mad

Hi @Akinbola247,

I've reviewed your contribution and made some formatting edits. It's looking nice! Just a couple of final touches are needed:

• Could you embed links to references within the chapter? This would enable students to delve deeper into the topics. For instance, a link to documentation on fuzz tests or other cheat codes would be beneficial.
• a brief summary at the end highlighting key takeaways would be a great addition.

Thank you once more!

Hi @omarespejel i've added the reference links and key take aways. You can check the PR here #229