This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
ch04-02-hello-account update #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ieKamau/starknetbook into ch04-00-account-abstraction
omarespejel
approved these changes
Oct 29, 2023
|
Hey @CyndieKamau! This is looking amazing, I will review and come back with feedback if necessary. Then I will go on to review your deployment PR. |
imgbot bot
pushed a commit
to hardiktheprogrammer/starknetbook
that referenced
this pull request
Jan 28, 2024
* update ch04-01-accounts.md * project setup, snip-6, protocol-only fns * create an account contract from scratch * delete ch04-02-hello-account.md, ch04-02-hello-account2.md * delete ch04-02-hello-account.md, ch04-02-hello-account2.md * format doc * setup starkli for deployment * switch ch04-02-02-deploy-hello-account.md to branch ch04-02-02-account-deployment --------- Co-authored-by: Omar U. Espejel <espejelomar@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @omarespejel I divided ch04-02-hello-account into two subchapters;
ch04-02-01-hello-account.md -> Creating an account contract from scratch
ch04-02-02-deploy-hello-account.md -> Deployment and interaction with account in Starkli
I've currently stashed ch04-02-02-deploy-hello-account.md I'm working on it.
For review I'm requesting the go-ahead on the two subchapters; Alternatively should I merge them into one?
Thanks!