Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helper for transaction receipt #1020

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

PhilippeR26
Copy link
Collaborator

Motivation and Resolution

New PR replacing PR #851 (due to creation of a new branch)

Usage related changes

see PR #851

Development related changes

see PR #851

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@ivpavici ivpavici mentioned this pull request Mar 19, 2024
6 tasks
Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tabaktoni tabaktoni changed the base branch from develop to next-version March 25, 2024 08:09
Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a free day to play with this to find a solution

@PhilippeR26
Copy link
Collaborator Author

Will need a free day to play with this to find a solution

Or can't we merge quickly to avoid again conflicts, and see this polishing aspect as soon as you have a free day.

@tabaktoni tabaktoni merged commit b656443 into starknet-io:next-version Mar 25, 2024
3 checks passed
@tabaktoni tabaktoni mentioned this pull request Mar 25, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants