-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handling of cairo u512 type #1022
Conversation
For u512, Starknet.js is waiting a Bignumberish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like there is some issue on validate ?
Problem from pr #1007 Solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will be addressed here keep-starknet-strange/abi-wan-kanabi#68 |
Motivation and Resolution
The new u512 Cairo type is now implemented.
Solve issue #1013.
According to https://github.com/starkware-libs/cairo/blob/07484c52791b76abcc18fd86265756904557d0d2/corelib/src/test/integer_test.cairo#L767
The raw format is :
Usage related changes
User send a BigNumberish, and receive a bigint.
Development related changes
A new file is in utils/cairoDataTypes, inspired from the Cairo u256 type.
Checklist: