Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type guard to receipt response status methods #1038

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

tabaktoni
Copy link
Collaborator

Motivation and Resolution

@PhilippeR26 This is one of the mods, but there is also a new multi-type guard in the latest TS, that than can narrow type based on multiple conditions
https://devblogs.microsoft.com/typescript/announcing-typescript-5-3/#switch-true-narrowing

RPC version (if applicable)

...

Usage related changes

  • Change 1.
  • ...

Development related changes

  • Change 1.
  • ...

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@tabaktoni tabaktoni merged commit 4b2398a into next-version Mar 25, 2024
3 checks passed
@tabaktoni tabaktoni mentioned this pull request Mar 25, 2024
6 tasks
@penovicp penovicp deleted the fix-transaction-receipt-success-guard branch April 3, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant