Bugfix: binary deserialization Felt
#89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also changes the serialization from sequence to bytes, but given that the deserialization wasn't working this should be a safe change to make.
dan-starkware
requested changes
Sep 5, 2024
dan-starkware
approved these changes
Sep 9, 2024
0xLucqs
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feltsupports both human readable and binary serialization, but the binary deserializer was missing.Does this introduce a breaking change?
Yes, but likely no-one is affected by it as deserialization was not working. The (de)serialization is done with bytes rather than sequences.
Other information
The serialization and deserialization test have been combined. Serialization and deserialization should not be tested separately as that makes it too easy to miss a case.