Added corelib version validation when loading db.

[orizi]

This change is 

[maciektr]

Reviewed 7 of 11 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware and @mkaput)

[piotmag769]

Reviewed 5 of 11 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware, @mkaput, and @orizi)

---

crates/cairo-lang-filesystem/src/db.rs line 44 at r3 (raw file):

    pub edition: Edition,
    /// The crate's version.
    pub version: Option<Version>,

This field is ignored for everything but corelib. Can we instead change ProjectConfig to

pub struct ProjectConfig {
    // ...
    pub corelib: CorelibConfiguration,
   // ...
}

pub struct CorelibConfiguration {
    pub root: Option<Directory>,
    pub version: Version,  // or `Option<Version>`
}

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware, @mkaput, and @piotmag769)

---

crates/cairo-lang-filesystem/src/db.rs line 44 at r3 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

This field is ignored for everything but corelib. Can we instead change ProjectConfig to

pub struct ProjectConfig {
    // ...
    pub corelib: CorelibConfiguration,
   // ...
}

pub struct CorelibConfiguration {
    pub root: Option<Directory>,
    pub version: Version,  // or `Option<Version>`
}

currently only for it - but i see no good reason to actually separate.

[piotmag769]

Reviewed 2 of 11 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware, @mkaput, and @orizi)

---

crates/cairo-lang-filesystem/src/db.rs line 44 at r3 (raw file):

Previously, orizi wrote…

currently only for it - but i see no good reason to actually separate.

What other crate versions would you want to validate in the compiler? I think everything else should be responsibility of a package manager (Scarb), it mixes abstraction layers

[orizi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware, @mkaput, and @piotmag769)

---

crates/cairo-lang-filesystem/src/db.rs line 44 at r3 (raw file):

Previously, piotmag769 (Piotr Magiera) wrote…

What other crate versions would you want to validate in the compiler? I think everything else should be responsibility of a package manager (Scarb), it mixes abstraction layers

i don't know what i would have wanted to check - but this specific check is due to the setup possibly changing the configuration.

if i cannot take the version from a specific crate - but only from the corelib - i won't be capable of checking anything.

Additionally, in the future, when starknet crate is extracted from core - it would require similar checks.

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware, @mkaput, and @piotmag769)

---

crates/cairo-lang-compiler/src/db.rs line 169 at r3 (raw file):

        if let Some(config) = &self.project_config {
            update_crate_roots_from_project_config(&mut db, config.as_ref());
            if let Some(corelib) = &config.corelib {

@piotmag769 unless you claim the entire validation should only happen due to this setup.

if so - i don't really understand why this isn't being directly solved at scarb level.

Code quote:

            if let Some(corelib) = &config.corelib {

[piotmag769]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @mkaput)

---

crates/cairo-lang-filesystem/src/db.rs line 44 at r3 (raw file):

Previously, orizi wrote…

i don't know what i would have wanted to check - but this specific check is due to the setup possibly changing the configuration.

if i cannot take the version from a specific crate - but only from the corelib - i won't be capable of checking anything.

Additionally, in the future, when starknet crate is extracted from core - it would require similar checks.

Not a fan of that, but will unblock

[piotmag769]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware, @mkaput, and @orizi)

---

crates/cairo-lang-compiler/src/db.rs line 169 at r3 (raw file):

Previously, orizi wrote…

@piotmag769 unless you claim the entire validation should only happen due to this setup.

if so - i don't really understand why this isn't being directly solved at scarb level.

This one is solved at Scarb level, so I didn't mean that

[gilbens-starkware]

Reviewed 11 of 11 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mkaput and @orizi)