Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made unreachable code diagnostics from errors into warnings. #6259

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 22, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi changed the base branch from spr/main/b3643991 to main August 22, 2024 08:55
@orizi orizi enabled auto-merge August 22, 2024 08:55
@orizi orizi added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 8b552ed Aug 22, 2024
44 checks passed
@orizi orizi deleted the spr/main/59b91bc5 branch August 28, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unreachable code should fire a warning with diagnostics, not an error
2 participants