-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support melodic compile #249
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some allow_failures from .travis.yml
Naoki-Hiraoka
force-pushed
the
fix-for-melodic
branch
from
April 10, 2020 14:36
50b6645
to
edfbcd5
Compare
Naoki-Hiraoka
changed the title
[WIP]support melodic compile
[WIP][on #248]support melodic compile
Apr 12, 2020
Naoki-Hiraoka
changed the title
[WIP][on #248]support melodic compile
[on #248]support melodic compile
Apr 13, 2020
Naoki-Hiraoka
changed the title
[on #248]support melodic compile
support melodic compile
Apr 13, 2020
This PR is included in #250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes #248.
gazebo::math
is completely deprecated inmelodic
.hydro
,indigo
andkinetic
supportsgazebo::math
.kinetic
andmelodic
supportsignition::math
http://gazebosim.org/tutorials?tut=install_dependencies_from_source
http://gazebosim.org/tutorials/?tut=ros_wrapper_versions
https://bitbucket.org/osrf/gazebo/src/default/Migration.md?fileviewer=file-view-default
Since API of
ignition::math
is different fromgazebo::math
, we cannot use clever methods like 11de69e, so we have to write"#ifdef #endif
everywheregazebo::math
is used.