Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filtering by date to buildQuery #816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enymawse
Copy link

Love the project and would like to contribute. I think this simple functionality would be a great addition to the API.

This PR implements date filtering using the following comparison methods: EQUALS, NOT_EQUALS, GREATER_THAN, LESS_THAN, IS_NULL, and NOT_NULL.

Open to feedback.

@enymawse
Copy link
Author

enymawse commented Sep 16, 2024

Looks like the functionality of actions/upload-artifact:v2 was finally switched off.

@InfiniteStash
Copy link
Collaborator

Looks like the functionality of actions/upload-artifact:v2 was finally switched off.

Yep! A fix was merged in yesterday so if you rebase it should build correctly.

@enymawse
Copy link
Author

@InfiniteStash Sort of new to this but do I need to squash the commits before the workflows will run again? It seems like they are just awaiting approval.

@enymawse
Copy link
Author

@InfiniteStash any word on a merge?

@enymawse enymawse force-pushed the graphql-query-date-filtering branch 2 times, most recently from ad77791 to 11314c5 Compare November 14, 2024 15:15
@enymawse enymawse marked this pull request as draft November 14, 2024 15:17
@enymawse enymawse marked this pull request as ready for review November 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants