Sub second marker timestamp precision #5431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5382
Allows specifying marker times by frame within seconds:
Frames are specified with a trailing
.ffff
which is the 0-based frame number.Times with a fractional component are formatted as
[hh:]mm:ss.ffff
- frame number 12 at time3:45
is displayed as3:45:0012
. The time field accepts the same value without the leading zeroes as well, ie3:45.12
, but will be re-formatted to the other format.Times at frame 0 are accepted and displayed without the
.ffff
suffix.Times from the current frame of the video will include sub-second precision.
The length of the
ffff
field was an arbitrary choice and I'm happy to hear alternatives.This PR will be rebased once #5311 is merged.