Implement Pause Restic #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptadas
reviewed
Feb 5, 2018
test/e2e/deployment_test.go
Outdated
| f.EventualEvent(restic.ObjectMeta).Should(WithTransform(f.CountSuccessfulBackups, BeNumerically(">=", 1))) | ||
|
|
||
| By(`Patching Restic with "paused: true"`) | ||
| err = f.PatchRestic(&restic, func(in *api.Restic) *api.Restic { |
There was a problem hiding this comment.
assign newly patched restic or, use CreateOrPatch in next patch.
diptadas
reviewed
Feb 5, 2018
test/e2e/deployment_test.go
Outdated
| @@ -28,6 +29,7 @@ var _ = Describe("Deployment", func() { | |||
| cred core.Secret | |||
| deployment apps.Deployment | |||
| recovery api.Recovery | |||
| previousBackupCount int64 | |||
There was a problem hiding this comment.
Don't need to define it globally.
diptadas
reviewed
Feb 5, 2018
pkg/docker/checks.go
Outdated
| @@ -1,7 +1,7 @@ | |||
| package docker | |||
|
|
|||
| const ( | |||
| ACRegistry = "appscode" | |||
| ACRegistry = "emruzhossain" | |||
There was a problem hiding this comment.
You can set it here for running e2e tests.
diptadas
approved these changes
Feb 6, 2018
tamalsaha
reviewed
Feb 6, 2018
pkg/backup/backup.go
Outdated
| @@ -189,6 +189,9 @@ func (c *Controller) setup() (*api.Restic, error) { | |||
| } | |||
|
|
|||
| func (c *Controller) runResticBackup(resource *api.Restic) (err error) { | |||
| if resource.Spec.Paused == true { | |||
| return nil | |||
There was a problem hiding this comment.
log.Infoln("skipped logging since restic is paused.")
tamalsaha
reviewed
Feb 6, 2018
pkg/controller/daemonsets.go
Outdated
| @@ -59,7 +59,9 @@ func (c *StashController) runDaemonSetInjector(key string) error { | |||
| } | |||
|
|
|||
| if newRestic != nil && !util.ResticEqual(oldRestic, newRestic) { | |||
| return c.EnsureDaemonSetSidecar(ds, oldRestic, newRestic) | |||
| if newRestic.Spec.Paused == false { | |||
tamalsaha
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #279