Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Ensure minimum-stability is dev before requiring new addon #10814

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

duncanmcclean
Copy link
Member

This pull request fixes an issue with the php please make:addon command where Composer will throw an error when requiring a new addon when an app's minimum-stability setting is anything other than dev.

@jasonvarga
Copy link
Member

Ideally we should avoid that.

If you don't have mininum-stability, you're still able to do composer require my/addon dev-master and it'll work.

It's just a matter of figuring out what branch it needs. dev-master or dev-main. Composer figures it out under the hood somehow. Maybe we can lift the logic from there. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants