Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show 'toggle all' checkbox if max_items is 1 #4309

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Don't show 'toggle all' checkbox if max_items is 1 #4309

merged 1 commit into from
Sep 28, 2021

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Sep 25, 2021 •
edited by jasonvarga
Loading

This pull request partly addresses #4246 by hiding the 'toggle all' checkbox in the Asset Browser if max_items on the field is 1.

@jasonvarga
Copy link
Member

This only prevents the toggle if max_files is 1.

If you set the max_files to another number, you can still click the toggle and end up selecting more than you should.

Thanks though!

@jasonvarga jasonvarga closed this Sep 28, 2021
@duncanmcclean
Copy link
Member Author

Doh! Should have thought of that - sorry!

@duncanmcclean duncanmcclean deleted the fix/4246 branch September 28, 2021 15:35
@jasonvarga
Copy link
Member

Actually it's still a good change to make.

@duncanmcclean duncanmcclean restored the fix/4246 branch September 28, 2021 15:35
@jasonvarga jasonvarga reopened this Sep 28, 2021
@jasonvarga jasonvarga merged commit f54d62e into statamic:3.2 Sep 28, 2021
@duncanmcclean duncanmcclean deleted the fix/4246 branch September 28, 2021 15:48
@ncla ncla mentioned this pull request Oct 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duncanmcclean @jasonvarga