Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom cell executions, "temp file" mode #302

Merged
merged 18 commits into from
Jul 20, 2023
Merged

Conversation

mxsdev
Copy link
Contributor

@mxsdev mxsdev commented Jun 14, 2023

Adds the following options to ExecuteRequest:

  • command_mode - either INLINE_SHELL, which sends commands to -c as an argument, or TEMP_FILE, which puts the contents of the script into a temporary file in the given directory, and uses the filename as an argument for the script
  • language_id - optional language id of code block, used to try and auto-resolve the program to run with
  • file_extension - File extension for TEMP_FILE mode. If omitted, it tries to resolve this from language_id.

Local & remote runners are integrated with this, and will try and auto-resolve the program to use based on the language id. Users can also use the program annotation to select a program manually.

Depends on #292

Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mxsdev mxsdev merged commit 76f5a86 into main Jul 20, 2023
4 checks passed
@joseeantonior joseeantonior deleted the mxsdev/shebang branch November 20, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants