Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/tls: rotate tls 7 days ahead #346

Merged
merged 4 commits into from
Jul 31, 2023
Merged

internal/tls: rotate tls 7 days ahead #346

merged 4 commits into from
Jul 31, 2023

Conversation

mxsdev
Copy link
Contributor

@mxsdev mxsdev commented Jul 20, 2023

Enables using pre-existing tls certificate, and re-generates 7 days ahead of the certificate's expiration date.

@mxsdev mxsdev marked this pull request as draft July 20, 2023 17:40
@mxsdev mxsdev marked this pull request as ready for review July 20, 2023 21:54
@mxsdev mxsdev requested a review from sourishkrout July 20, 2023 21:54
sourishkrout
sourishkrout approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@sourishkrout sourishkrout merged commit 796a085 into main Jul 31, 2023
4 checks passed
@sourishkrout sourishkrout deleted the mxsdev/tls-rotation branch July 31, 2023 22:05
@sourishkrout sourishkrout mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourishkrout sourishkrout sourishkrout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxsdev @sourishkrout