-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fifo based shell env collector #617
Conversation
bc7afcb
to
c25ba5e
Compare
26ab70b
to
88eb7d3
Compare
@sourishkrout as this is a big change to a crucial component, I would recommend a three-step release:
|
A release in stages makes sense. These changes are not affecting runner v1, right? If so, we can skip on step ahead and as long as beta commands v2 in the extension is still opt-in, we can test-drive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM. Let's merge and then figure out the release strategy.
It's a good point. It does not affect v1. |
Quality Gate passedIssues Measures |
Replace the shell env collector from a file-based to named pipe-based (fifo). For Windows, it will be a named pipe, but it will be done in a follow-up PR. Also, the env dump regardless of the destination is encrypted.
The encryption is mostly to avoid leaking secrets by accidents. Our threat model assumes execution of runme by the same user without any additional isolation.
Enablement of this feature is controlled by two vars: