Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AI Service Protocol Definition #662

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Remove AI Service Protocol Definition #662

merged 2 commits into from
Sep 5, 2024

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Sep 2, 2024

* Foyle is now publishing its protos to the buf registry and the client libraries
  pulled from the registry are what's used by the vscode extension.
* The AI service defined in the runme repository is no longer needed.
* Related to jlewi/foyle#173
@jlewi jlewi marked this pull request as ready for review September 2, 2024 22:44
Copy link
Member

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Copy link

sonarcloud bot commented Sep 4, 2024

@jlewi jlewi merged commit b4bad1d into main Sep 5, 2024
7 checks passed
@jlewi jlewi deleted the jlewi/protocleanup branch September 5, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants